3744 Add save_state utility to handle saving logic
#3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
/build |
wyli
reviewed
Feb 8, 2022
wyli
approved these changes
Feb 8, 2022
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
/build |
|
Hi @wyli , I totally updated the Thanks in advance. |
|
/build |
wyli
requested changes
Feb 9, 2022
wyli
reviewed
Feb 9, 2022
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
/build |
wyli
approved these changes
Feb 9, 2022
wyli
pushed a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] add save_state utility Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add atomic and func Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] refactor saving logic Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] restore persistent dataset Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] simplify kwargs Signed-off-by: Nic Ma <nma@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3744 .
Description
Currently, we already have the
copy_model_stateutility to help loadstate_dict, this PR added thesave_stateutility to help simplify the model saving logic. Users easy to face the multi-gpu saving issue (likestate_dict.modulein #3744 ) and may need to save multiple objects in a dict.And we also received the requests for such a saving utility from NVIDIA Clara users, especially when saving model in BYOW logic without ignite, etc.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.