Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3708 - refactor testing data fetching and migrate to release assets #3814

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Feb 17, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3708

Description

testing data are now also available here

this PR unified the config file to organise the testing data

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Feb 17, 2022

/build

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Looks good to me.

@Nic-Ma Nic-Ma requested review from IsaacYangSLA and pxLi February 18, 2022 03:25
Copy link
Contributor

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nit: data_config keys length and name check as the fixed format, but not a big deal :)

@wyli
Copy link
Contributor Author

wyli commented Feb 18, 2022

/build

@wyli
Copy link
Contributor Author

wyli commented Feb 18, 2022

LGTM.

nit: data_config keys length and name check as the fixed format, but not a big deal :)

Thanks @pxLi as you can see all the ci jobs will download and cache these testing data to the "testing_data" folder. Would be great to have a shared space for them at runtime to avoid repeated downloading...

@wyli wyli merged commit bcbfbdd into Project-MONAI:dev Feb 18, 2022
@wyli wyli deleted the 3708-migrate-testing-data branch February 18, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

migrate monai testing/demo data to GitHub release assets
3 participants