Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reshape in ViTAutoEnc #3841

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Fix reshape in ViTAutoEnc #3841

merged 4 commits into from
Feb 22, 2022

Conversation

razorx89
Copy link
Contributor

Description

The current implementation of ViTAutoEnc always expects a cubic volume shape and does not reshape the output sequence of ViT based on the patch and volume size. Thus for non-cubic volumes, this results in an exception because the reshape operation fails.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Sven Koitka <sven.koitka@uk-essen.de>
Signed-off-by: Sven Koitka <sven.koitka@uk-essen.de>
Signed-off-by: Sven Koitka <sven.koitka@uk-essen.de>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Feb 22, 2022

/build

@wyli wyli enabled auto-merge (squash) February 22, 2022 13:56
@wyli wyli merged commit 2cfb896 into Project-MONAI:dev Feb 22, 2022
@razorx89 razorx89 deleted the fix-vitautoenc-shape branch February 22, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants