Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3482 add export script for TorchScript file #3965

Merged
merged 34 commits into from
Mar 24, 2022
Merged

3482 add export script for TorchScript file #3965

merged 34 commits into from
Mar 24, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 17, 2022 •
edited
Loading

Task step 4 and 13 of #3482 .

Description

This PR added export script to export the model, config, metadata to a TorchScript file.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 15 commits February 1, 2021 19:15
@Nic-Ma
Merge pull request #19 from Project-MONAI/master
42a45e0 
merge master
@Nic-Ma
Merge pull request #32 from Project-MONAI/master
cd16a13 
merge master
@Nic-Ma
Merge pull request #180 from Project-MONAI/dev
6f87afd 
merge master
@Nic-Ma
Merge pull request #214 from Project-MONAI/dev
f398298 
merge master
@Nic-Ma
Merge pull request #388 from Project-MONAI/dev
c86d6b6 
merge master
@Nic-Ma
[DLMED] add export script
59a7524 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Merge branch 'dev' into 3482-add-export-script
87e87ca
@Nic-Ma
[DLMED] add base unit test
8d54283 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Merge branch 'dev' into 3482-add-export-script
ddf1c8d
@Nic-Ma
Merge branch 'dev' into 3482-add-export-script
6d4b7e4
@Nic-Ma
[DLMED] add custom config item types and reference resolver
b750b73 
Signed-off-by: Nic Ma <nma@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
36d8469 
for more information, see https://pre-commit.ci
@Nic-Ma
[DLMED] enhance doc-string
1fbd385 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Merge branch '3482-add-export-script' of https://github.com/Nic-Ma/MONAI
81ac67e 
 into 3482-add-export-script
@Nic-Ma
[DLMED] fix typo
5c23353 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title [WIP] 3482 add export script and customized ConfigItem and ReferenceResolver 3482 add export script and customized ConfigItem and ReferenceResolver Mar 18, 2022
@Nic-Ma Nic-Ma marked this pull request as ready for review March 18, 2022 10:41
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 18, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 18, 2022

/build

@Nic-Ma
[DLMED] add logging
b5b9f20 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 3482-add-export-script branch from 202aff5 to b5b9f20 Compare March 18, 2022 10:53
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 18, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 18, 2022 10:54
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 21, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 21, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 21, 2022

Hi @ericspod @wyli ,

This PR is ready for review, it adds export script and support customized ConfigItem and ReferenceResolver in ConfigParser.
Could you please help review it when you are available?

Thanks in advance.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 22, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 22, 2022

/build

@Nic-Ma Nic-Ma requested a review from wyli March 22, 2022 23:26
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 22, 2022

/build

@wyli
Copy link
Contributor

wyli commented Mar 23, 2022

thanks, I just saw that subprocess.check_call in the unit tests wouldn't count towards the total code coverage, could you help have a fix? is it possible to use coverage as the sys.executable?

wyli and others added 2 commits March 23, 2022 09:55
@wyli
Copy link
Contributor

wyli commented Mar 23, 2022

/integration-test

@Nic-Ma
[DLMED] change to coverage
26f3ec4 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 23, 2022

thanks, I just saw that subprocess.check_call in the unit tests wouldn't count towards the total code coverage, could you help have a fix? is it possible to use coverage as the sys.executable?

Hi @wyli ,

Sure, I updated to use coverage run instead.
Could you please help take a look again?

Thanks in advance.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 23, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 23, 2022

/build

@wyli
update integration tests
fce2bd7 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Mar 23, 2022

/integration-test

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 23, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 23, 2022

/build

1 similar comment
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 24, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) March 24, 2022 00:22
@pxLi
Copy link
Contributor

pxLi commented Mar 24, 2022

/build

@Nic-Ma
[DLMED] fix blossom
1db8f00 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma disabled auto-merge March 24, 2022 04:24
@Nic-Ma Nic-Ma enabled auto-merge (squash) March 24, 2022 04:25
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 24, 2022

/build

2 similar comments
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 24, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 24, 2022

/build

@Nic-Ma Nic-Ma merged commit bfda331 into Project-MONAI:dev Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

@wyli wyli Awaiting requested review from wyli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nic-Ma @wyli @pxLi @ericspod