Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3482 Add support for customized ConfigItem and resolver #3980

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 22, 2022

Task step 13 of #3482 .

Description

This PR added support for customized ConfigItem and resolver in ConfigParser.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 22, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 22, 2022

/build

@Nic-Ma Nic-Ma requested review from wyli, ericspod and rijobro March 22, 2022 15:20
@wyli
Copy link
Contributor

wyli commented Mar 23, 2022

thanks, I think we should consider this optional feature later when the module is more stable...Perhaps we remove this feature from #3482? probably it's not part of an MVP.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 23, 2022

thanks, I think we should consider this optional feature later when the module is more stable...Perhaps we remove this feature from #3482? probably it's not part of an MVP.

Hi @wyli ,

We added this task to #3482 when we were analyzing @dongyang0122 's YAML config for DiNTS, it can be supported by a customized ConfigComponent.

Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 23, 2022

/build

@Nic-Ma Nic-Ma mentioned this pull request Mar 24, 2022
17 tasks
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 31, 2022

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants