Skip to content

3482 Add support to set config file for logging module #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 24, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Mar 24, 2022

Task step 15 of #3482 .

Description

This PR added support to set config file for logging module.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 24, 2022

/black

monai-bot and others added 3 commits March 24, 2022 08:41
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title [WIP] 3482 Add support to set config file for logging module 3482 Add support to set config file for logging module Mar 24, 2022
@Nic-Ma Nic-Ma mentioned this pull request Mar 24, 2022
17 tasks
@Nic-Ma Nic-Ma marked this pull request as ready for review March 24, 2022 11:20
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 24, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Mar 24, 2022

/build

@Nic-Ma Nic-Ma merged commit 03f8d80 into Project-MONAI:dev Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants