Skip HoVerNet Loss for pytorch 1.9.1 and older #5401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Member
Author
|
Hi @wyli, checking the release note for PyTorch 1.10, I did not find anything that can effect this but the code does not work with any version earlier than that. There should be something related to the cross entropy. |
wyli
approved these changes
Oct 25, 2022
Contributor
|
/build |
JHancox
added a commit
to JHancox/MONAI
that referenced
this pull request
Oct 28, 2022
For CrossEntropy, PyTorch v1.10+ allows target values to be either class probabilities or indices, whereas v1.9- only allows for class indices, so class indices are now used. This should provide a better solution for Project-MONAI#5393 and remove the need for Project-MONAI#5401 Signed-off-by: JHancox <48477639+JHancox@users.noreply.github.com>
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
Signed-off-by: KumoLiu <yunl@nvidia.com>
bhashemian
added a commit
that referenced
this pull request
Nov 4, 2022
Fixes #5469 ### Description For CrossEntropy, PyTorch v1.10+ allows target values to be either class probabilities or indices, whereas v1.9- only allows for class indices, so class indices are now used. This should provide a better solution for #5393 and remove the need for #5401 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). Signed-off-by: JHancox <48477639+JHancox@users.noreply.github.com> Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> Co-authored-by: Behrooz <3968947+drbeh@users.noreply.github.com>
wyli
pushed a commit
that referenced
this pull request
Nov 6, 2022
Fixes #5469 ### Description For CrossEntropy, PyTorch v1.10+ allows target values to be either class probabilities or indices, whereas v1.9- only allows for class indices, so class indices are now used. This should provide a better solution for #5393 and remove the need for #5401 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). Signed-off-by: JHancox <48477639+JHancox@users.noreply.github.com> Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> Co-authored-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5393
Description
HoVerNet Loss works with PyTorch 1.10 and newer
Types of changes