Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4855 5860 update the pending transform utilities #5916

Merged
merged 19 commits into from
Feb 1, 2023
Merged

4855 5860 update the pending transform utilities #5916

merged 19 commits into from
Feb 1, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 30, 2023 •
edited
Loading

one of the sub-PRs from #5860

also fixes #5509, by reviewing the metetensor copying in loadimage

Description

This PR mainly to enhance the apply_transforms, resample, push_transform APIs
to get prepared for lazy resampling.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 7 commits January 30, 2023 15:54
@wyli
revivse utilities
d639b83 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
adding new traceable keys
c30dbc8 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update apply
23ccf83 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update utilities
17f4e53 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update tests
4727d60 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
backward compatible
696e411 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes Project-MONAI#5509
47684d7 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 2 commits January 30, 2023 22:28
@wyli
update types
c508d5a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes docstrings
d562e01 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review January 30, 2023 22:45
wyli added 2 commits January 31, 2023 00:09
@wyli
fixes merging issues
5824f78 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
default affine
49eaa5f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@Nic-Ma Nic-Ma requested a review from KumoLiu January 31, 2023 03:18
Nic-Ma
Nic-Ma reviewed Jan 31, 2023
View reviewed changes
monai/data/meta_obj.py Outdated Show resolved Hide resolved
monai/transforms/inverse.py Outdated Show resolved Hide resolved
monai/transforms/lazy/functional.py Show resolved Hide resolved
wyli added 2 commits January 31, 2023 10:27
@wyli
update based on comments
ab7c44c 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update based on comments
9eec6b0 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jan 31, 2023

/build

wyli added 3 commits January 31, 2023 12:05
@wyli
fixes typing
0ad9279 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update based on comments
1e039ad 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Merge remote-tracking branch 'upstream/dev' into minor-fixes
234e326 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from Nic-Ma January 31, 2023 15:19
Nic-Ma
Nic-Ma approved these changes Feb 1, 2023
View reviewed changes
monai/utils/misc.py Outdated Show resolved Hide resolved
wyli added 2 commits February 1, 2023 06:18
@wyli
update based on comments
710d126 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes memory layout
b0def3e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Feb 1, 2023 •
edited
Loading

/black
/build

@wyli
Copy link
Contributor Author

wyli commented Feb 1, 2023

/build

@wyli wyli enabled auto-merge (squash) February 1, 2023 09:48
@wyli wyli merged commit b592164 into Project-MONAI:dev Feb 1, 2023
@wyli wyli deleted the minor-fixes branch February 1, 2023 10:22
@wyli wyli mentioned this pull request Feb 1, 2023
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv left review comments

@KumoLiu KumoLiu KumoLiu left review comments

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoadImageD and MetaTensor
4 participants
@wyli @Nic-Ma @KumoLiu @yiheng-wang-nv