Added callable options for iteration_log and epoch_log in StatsHandler #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Project-MONAI#5964 Signed-off-by: vfdev-5 <vfdev.5@gmail.com>
vfdev-5
force-pushed
the
issue-5964-statshandler-override-args
branch
from
9f52d54
to
1488b06
Compare
wyli
approved these changes
Feb 9, 2023
vfdev-5
commented
Feb 9, 2023
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
update to use parameterized
|
@wyli I wonder which job actually runs test_handler_stats.py, can you please put a link on it ? |
|
/build |
ericspod
reviewed
Feb 9, 2023
ericspod
reviewed
Feb 9, 2023
|
I had a few minor suggestions but looks like a good change! |
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: vfdev <vfdev.5@gmail.com>
for more information, see https://pre-commit.ci
Nic-Ma
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Hi @vfdev-5 ,
Looks good to me.
Could you please help also enable this feature for other very similar handlers? Like:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/handlers/tensorboard_handlers.py#L94
And:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/handlers/mlflow_handler.py#L101
Thanks in advance.
|
@Nic-Ma yes, I can take a look on that in a follow-up PR |
|
/build |
7 tasks
wyli
added a commit
to wyli/MONAI
that referenced
this pull request
Feb 13, 2023
Project-MONAI#5965) Fixes Project-MONAI#5964 ### Description Added callable options for iteration_log and epoch_log in StatsHandler. Ref: Project-MONAI#5958 (reply in thread) ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: vfdev-5 <vfdev.5@gmail.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com> Signed-off-by: vfdev <vfdev.5@gmail.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com> Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
wyli
pushed a commit
that referenced
this pull request
Feb 20, 2023
… and MLFlow (#5976) Follow-up PR on extending `iteration_log`/`epoch_log` functionality ### Description > Could you please help also enable this feature for other very similar handlers? Like: https://github.com/Project-MONAI/MONAI/blob/dev/monai/handlers/tensorboard_handlers.py#L94 And: https://github.com/Project-MONAI/MONAI/blob/dev/monai/handlers/mlflow_handler.py#L101 - #5965 (review) ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5964
Description
Added callable options for iteration_log and epoch_log in StatsHandler.
Ref: #5958 (reply in thread)
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.