Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6028 6041 Upgrade ignite dependency to 0.4.11 #6067

Merged
merged 12 commits into from
Feb 27, 2023
Merged

6028 6041 Upgrade ignite dependency to 0.4.11 #6067

merged 12 commits into from
Feb 27, 2023

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 27, 2023 •
edited
Loading

Fixes #6028 .
Fixes #6041 .

Description

This PR upgraded the ignite version of dependency to the latest 0.4.11.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 27, 2023

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 27, 2023

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 27, 2023

I have tested the test_integration_workflows.py locally and it passed successfully.
I didn't upgrade the requirement of MonaiAlgo for ignite, keep 0.4.10 as the min requirement version.
CC @holgerroth .

Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 27, 2023

CC @vfdev-5

@Nic-Ma Nic-Ma changed the title 6028 Upgrade ignite dependency to 0.4.11 6028 6041 Upgrade ignite dependency to 0.4.11 Feb 27, 2023
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 27, 2023

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 27, 2023

/build

wyli
wyli approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

earlier I saw some errors https://github.com/Project-MONAI/MONAI/actions/runs/4279364930 do you know the reason?

create_supervised_trainer is used in quite a few places..
https://github.com/search?q=org%3AProject-MONAI+create_supervised_trainer&type=code

@wyli wyli enabled auto-merge (squash) February 27, 2023 12:03
@wyli wyli disabled auto-merge February 27, 2023 12:04
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 27, 2023

earlier I saw some errors https://github.com/Project-MONAI/MONAI/actions/runs/4279364930 do you know the reason?

create_supervised_trainer is used in quite a few places.. https://github.com/search?q=org%3AProject-MONAI+create_supervised_trainer&type=code

Yes, that because ignite added more args to the API, already fixed in the latest commit.

Thanks.

@Nic-Ma Nic-Ma enabled auto-merge (squash) February 27, 2023 15:19
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 27, 2023

/build

@Nic-Ma Nic-Ma merged commit b30ea42 into Project-MONAI:dev Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@holgerroth holgerroth Awaiting requested review from holgerroth

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate create_multi_gpu_supervised_trainer APIs Upgrade ignite dependency to 0.4.11
2 participants
@Nic-Ma @wyli