Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6109 no mutate ratio /user inputs croppad #6127

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Mar 10, 2023

Fixes #6109

Description

  • use tuples for user inputs to avoid changes
  • enhance the type checks
  • fixes issue of ratios in RandCropByLabelClasses

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 3 commits March 10, 2023 12:37
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
…inputs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review March 10, 2023 13:24
@wyli
Copy link
Contributor Author

wyli commented Mar 13, 2023

/build

@wyli wyli merged commit a8302ec into Project-MONAI:dev Mar 13, 2023
@wyli wyli deleted the 6109-no-mutate-user-inputs branch March 13, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RandCropByLabelClasses, internal variable "ratios" is mutated
2 participants