Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6136 6146 update the default writer flag #6147

Merged
merged 13 commits into from
Mar 16, 2023
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Mar 14, 2023

Fixes #6136
fixes #6146

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title 6136 update the default writer flag 6136 6146 update the default writer flag Mar 14, 2023
@wyli wyli marked this pull request as ready for review March 15, 2023 00:14
monai/data/image_writer.py Outdated Show resolved Hide resolved
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from ericspod and KumoLiu and removed request for ericspod March 15, 2023 17:21
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, LGTM.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
monai/data/image_writer.py Outdated Show resolved Hide resolved
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Mar 16, 2023

/build

@wyli wyli enabled auto-merge (squash) March 16, 2023 18:09
@wyli wyli merged commit 66d0478 into Project-MONAI:dev Mar 16, 2023
@wyli wyli deleted the 6136-itk-writer branch March 25, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants