Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports for AMD GPU #6161

Merged
merged 7 commits into from
May 24, 2023
Merged

Add supports for AMD GPU #6161

merged 7 commits into from
May 24, 2023

Commits on Mar 15, 2023

  1. add Dockerfile.amd to build MONAI docker image for AMD GPU. The file …

    …is based on Dockerfile for NVIDIA GPU.
    yaomingamd committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    018609c View commit details
    Browse the repository at this point in the history
  2. add ROCm HIP support

         1. replace __shfl_down_sync(0xffffffff, ...) with __shfl_down(...)
                    __shfl_xor_sync(0xffffffff,...) with __shfl_xor(...)
            for AMD ROCm HIP
         2. replace dim3 integer vector initialization { , , } with dim3( , , )
            for AMD ROCm HIP
    yaomingamd committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    a8cfcf6 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Configuration menu
    Copy the full SHA
    e83e77f View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. DCO Remediation Commit for Yaoming Mu <yaoming.mu@amd.com>

    I, Yaoming Mu <yaoming.mu@amd.com>, hereby add my Signed-off-by to this commit: 018609c
    I, Yaoming Mu <yaoming.mu@amd.com>, hereby add my Signed-off-by to this commit: a8cfcf6
    
    As discussed with MONAI team, moves DOckerfile.amd from this PR. The existing file "Dockerfile" will be refactored to allow build images for different GPUs.
    
    Signed-off-by: Yaoming Mu <yaoming.mu@amd.com>
    yaomingamd committed May 24, 2023
    Configuration menu
    Copy the full SHA
    59f7827 View commit details
    Browse the repository at this point in the history
  2. As suggested by ericspod( Eric Kerfoot), using macros functions to re…

    …duce the amount of codes. Currently AMD HIP does not support __shfl_xxx_sync functions as NVIDIA CUDA, but when mask is 0xffffffff, __shfl_xxx_sync would be replaced by __shfl_xxx for the codes in gmm_cuda.cu
    
    run unittest tests/test_gmm.py for NVIDIA and AMD GPUs and tests passed.
    
    Signed-off-by: Yaoming Mu <yaoming.mu@amd.com>
    yaomingamd committed May 24, 2023
    Configuration menu
    Copy the full SHA
    c218cea View commit details
    Browse the repository at this point in the history
  3. [MONAI] code formatting

    Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
    monai-bot committed May 24, 2023
    Configuration menu
    Copy the full SHA
    8445097 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'dev' into amd_dev

    wyli authored May 24, 2023
    Configuration menu
    Copy the full SHA
    ca4eafc View commit details
    Browse the repository at this point in the history