Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onnx export to support older pytorch with example_outputs argument #6309

Merged

Conversation

liqunfu
Copy link
Contributor

@liqunfu liqunfu commented Apr 5, 2023

Fixes # .
#6297

Description

PyTorch onnx exporter API has been changed since 1.10 to remove example_outputs as a required input argument. Special handling is added in this PR to support PyTorch version older than 1.10. Unit test is also extended to covert this case.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@wyli
Copy link
Contributor

wyli commented Apr 5, 2023

/build

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Apr 6, 2023

/build

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Apr 6, 2023

/integration-test

@wyli wyli enabled auto-merge (squash) April 6, 2023 11:00
@wyli wyli merged commit 06defb7 into Project-MONAI:dev Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants