Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture failures from auto3dseg related subprocess calls #6596

Merged
merged 17 commits into from
Jun 22, 2023

Conversation

mingxin-zheng
Copy link
Contributor

Fixes #6445 .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Mingxin <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin <18563433+mingxin-zheng@users.noreply.github.com>
@mingxin-zheng
Copy link
Contributor Author

/integration-test

Signed-off-by: Mingxin <18563433+mingxin-zheng@users.noreply.github.com>
monai/utils/misc.py Outdated Show resolved Hide resolved
@mingxin-zheng mingxin-zheng changed the title [WIP] Capture failures from auto3dseg related subprocess calls Capture failures from auto3dseg related subprocess calls Jun 18, 2023
@mingxin-zheng mingxin-zheng changed the title Capture failures from auto3dseg related subprocess calls [WIP] Capture failures from auto3dseg related subprocess calls Jun 18, 2023
Signed-off-by: Mingxin <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin <18563433+mingxin-zheng@users.noreply.github.com>
@mingxin-zheng mingxin-zheng changed the title [WIP] Capture failures from auto3dseg related subprocess calls Capture failures from auto3dseg related subprocess calls Jun 19, 2023
@mingxin-zheng
Copy link
Contributor Author

/integration-test

@wyli
Copy link
Contributor

wyli commented Jun 19, 2023

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Jun 20, 2023

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Jun 21, 2023

/build

@wyli wyli enabled auto-merge (squash) June 21, 2023 21:13
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Jun 21, 2023

/build

@wyli wyli merged commit 1aeb04d into Project-MONAI:dev Jun 22, 2023
@mingxin-zheng mingxin-zheng deleted the fix-6445 branch March 27, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output From Failed subprocess.run Calls Not Captured
3 participants