Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_image_filter test error #6624

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Fix test_image_filter test error #6624

merged 3 commits into from
Jun 19, 2023

Conversation

mingxin-zheng
Copy link
Contributor

Fixes #6622 .

Description

Add type check to avoid comparing a np.array with a string

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

Signed-off-by: Mingxin Zheng <mingxinz@nvidia.com>
@mingxin-zheng mingxin-zheng requested a review from wyli June 19, 2023 08:24
pre-commit-ci bot and others added 2 commits June 19, 2023 08:24
Signed-off-by: Mingxin <18563433+mingxin-zheng@users.noreply.github.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Jun 19, 2023

/build

@wyli wyli enabled auto-merge (squash) June 19, 2023 08:54
@wyli wyli merged commit 2cbed6c into Project-MONAI:dev Jun 19, 2023
@mingxin-zheng mingxin-zheng deleted the fix-6622 branch March 27, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_image_filter test error
2 participants