Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6777 fixes boolean indexing of batched metatensor #6781

Merged
merged 2 commits into from
Jul 27, 2023
Merged

6777 fixes boolean indexing of batched metatensor #6781

merged 2 commits into from
Jul 27, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jul 26, 2023

Fixes #6777

Description

  • skip metadata handling if the index is a tensor variable
  • make batched tensor handling a separate internal function for clarity

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
fixes
02c3e15 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from ericspod, Nic-Ma and KumoLiu July 26, 2023 12:22
@wyli wyli marked this pull request as ready for review July 26, 2023 16:52
@wyli
Copy link
Contributor Author

wyli commented Jul 26, 2023

/build

KumoLiu
KumoLiu approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wyli wyli merged commit 9e2d381 into Project-MONAI:dev Jul 27, 2023
32 checks passed
@wyli wyli deleted the fixes-issue-6777 branch July 27, 2023 06:55
@KumoLiu KumoLiu mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boolean indexing of batched metatensor
2 participants
@wyli @KumoLiu