Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6794 optionally pass coordinates to predictor during sliding window #6795

Merged
merged 3 commits into from
Sep 21, 2023
Merged

6794 optionally pass coordinates to predictor during sliding window #6795

merged 3 commits into from
Sep 21, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jul 29, 2023 •
edited
Loading

Fixes #6794

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Contributor Author

wyli commented Aug 5, 2023

/build

@wyli
update
bd87975 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
temp test
a1893f6 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
remove runtests change
0d2e89a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review September 21, 2023 06:11
KumoLiu
KumoLiu approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wyli
Copy link
Contributor Author

wyli commented Sep 21, 2023

/build

@wyli wyli enabled auto-merge (squash) September 21, 2023 06:26
@wyli wyli merged commit f3200b9 into Project-MONAI:dev Sep 21, 2023
25 of 30 checks passed
@wyli wyli deleted the 6794-coord-sw branch October 1, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

predictor access of coordinates in sliding_window_inference
2 participants
@wyli @KumoLiu