Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monai.bundle to support model zoo NGC hosting #6828

Merged
merged 7 commits into from
Aug 7, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Aug 7, 2023

Fixes #6761 .

Description

  • update download to support monaihosting download.
  • update relevant unit tests.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Aug 7, 2023

In this PR, I mainly update the download method.
It appears that there are still several other methods that need to be updated, such as get_all_bundles_list, get_bundle_versions, and get_bundle_info.

The NGC API doc does not, however, contain the API for the current monaihosting link. I can't currently get access to all of the bundles that exist; I can only get access to all of the version information given the name of a specific bundle. Do you think I can refer to the model_info.json method to update these methods or do you have any other suggestions?
cc @wyli @ericspod @Nic-Ma @yiheng-wang-nv

@KumoLiu KumoLiu marked this pull request as ready for review August 7, 2023 10:17
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me. I think we can merge this first, and create new feature requests about enhancing the other existing APIs.

@wyli
Copy link
Contributor

wyli commented Aug 7, 2023

/build

@wyli wyli enabled auto-merge (squash) August 7, 2023 12:51
@wyli wyli merged commit 5e6ce7c into Project-MONAI:dev Aug 7, 2023
25 of 30 checks passed
@KumoLiu KumoLiu deleted the bundle-download branch August 7, 2023 13:41
@yiheng-wang-nv
Copy link
Contributor

cc @zephyrie , model zoo web page may also need to be changed due to updated NGC hosting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update monai.bundle to support model zoo NGC hosting
3 participants