Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6676 port generative metrics #6836

Merged
merged 18 commits into from
Aug 16, 2023
Merged

6676 port generative metrics #6836

merged 18 commits into from
Aug 16, 2023

Conversation

marksgraham
Copy link
Contributor

@marksgraham marksgraham commented Aug 8, 2023

Work towards addressing #6676. Ports all metrics to MONAI.

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 3f9a492

Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me, just a minor comment inline, cc @mingxin-zheng please help confirm the PR

monai/metrics/fid.py Outdated Show resolved Hide resolved
marksgraham and others added 2 commits August 11, 2023 04:42
Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
monai/metrics/mmd.py Outdated Show resolved Hide resolved
Signed-off-by: Mark Graham <markgraham539@gmail.com>
…ingle mapping for y

Signed-off-by: Mark Graham <markgraham539@gmail.com>
@marksgraham marksgraham marked this pull request as ready for review August 15, 2023 14:22
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
@wyli
Copy link
Contributor

wyli commented Aug 16, 2023

/build

@wyli wyli merged commit 9ae72e4 into Project-MONAI:dev Aug 16, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants