Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor self.weight in DiceLoss and FocalLoss #7158

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Refactor self.weight in DiceLoss and FocalLoss #7158

merged 4 commits into from
Oct 24, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 24, 2023

Fixes #7065

Description

Remove self.weight in DiceLoss and FocalLoss

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#7065
42aa088 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
minor fix
5b4fe29 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
fix mypy
8713554 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu mentioned this pull request Oct 24, 2023
Merged
7 tasks
@KumoLiu KumoLiu requested review from myron and wyli October 24, 2023 03:37
@KumoLiu
fix ci
843131f 
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
wyli approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Oct 24, 2023

/build

@wyli wyli enabled auto-merge (squash) October 24, 2023 07:50
@wyli
Copy link
Contributor

wyli commented Oct 24, 2023

/build

@wyli wyli merged commit cc20c9b into Project-MONAI:dev Oct 24, 2023
28 checks passed
@KumoLiu KumoLiu deleted the weight branch October 25, 2023 02:41
@KumoLiu KumoLiu mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@myron myron Awaiting requested review from myron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DiceLoss add weight per class parameter
2 participants
@KumoLiu @wyli