Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support return dice for each class in DiceMetric #7163

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Support return dice for each class in DiceMetric #7163

merged 3 commits into from
Oct 25, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 25, 2023 •
edited
Loading

Fixes #7162
Fixes #7164

Description

Add return_with_label, if True or a list, will return the metrics with the corresponding label name, only works when reduction="mean_batch".
https://github.com/pytorch/ignite/blob/47b95d087a0f8713a9d24bcfe3a539b08101ba7a/ignite/metrics/metric.py#L424

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#7162
d34d505 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
fix Project-MONAI#7164
a2f069e 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu marked this pull request as ready for review October 25, 2023 10:10
wyli
wyli reviewed Oct 25, 2023
View reviewed changes
monai/metrics/meandice.py Outdated Show resolved Hide resolved
@KumoLiu
address comments
72b482d 
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
wyli approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Oct 25, 2023

/build

@wyli wyli enabled auto-merge (squash) October 25, 2023 20:59
@wyli wyli merged commit 85243f5 into Project-MONAI:dev Oct 25, 2023
28 checks passed
@KumoLiu KumoLiu deleted the meandice branch October 26, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when build docs Get Dice for each class in DiceMetric
2 participants
@KumoLiu @wyli