Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip "test_gaussian_filter" as a workaround for blossom killed #7474

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Feb 19, 2024

workaround for #7445

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@ericspod
Copy link
Member

Do we know if one test or another is causing the issue? In test_gaussian_filter.py there's tests doing backprop and others testing other things, can we keep any of these instead of ignoring the file?

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 20, 2024

/build

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 20, 2024

/build

2 similar comments
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 20, 2024

/build

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 20, 2024

/build

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 20, 2024

/build

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 20, 2024

Do we know if one test or another is causing the issue? In test_gaussian_filter.py there's tests doing backprop and others testing other things, can we keep any of these instead of ignoring the file?

Hi @ericspod, I still haven't found the root problem, I have discovered that this unit test is the cause and only occurs on v100. Additionally, it comes after PyTorch2.2, so I added a check only skip the test after 2.2, what do you think?

@ericspod
Copy link
Member

Hi @ericspod, I still haven't found the root problem, I have discovered that this unit test is the cause and only occurs on v100. Additionally, it comes after PyTorch2.2, so I added a check only skip the test after 2.2, what do you think?

Thanks @KumoLiu this looks good now if it works. Please add a comment with the skip decorators so that we are aware of why we're skipping if we want to come back to it in the future. We know there's a number of other inexplicable issues with tests combined with specific environments that we should circle back later.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 20, 2024

/build

@KumoLiu KumoLiu merged commit a8080fc into Project-MONAI:dev Feb 20, 2024
28 checks passed
@KumoLiu KumoLiu deleted the skip-ci branch February 20, 2024 14:18
juampatronics pushed a commit to juampatronics/MONAI that referenced this pull request Mar 25, 2024
…ct-MONAI#7474)

workaround for Project-MONAI#7445

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this pull request Apr 11, 2024
…ct-MONAI#7474)

workaround for Project-MONAI#7445

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants