-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Feature added: Get WSI at mpp #7574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NikolasSchmitz
wants to merge
78
commits into
Project-MONAI:dev
Choose a base branch
from
NikolasSchmitz:4980-get-wsi-at-mpp
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 31 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
f3e7d03
Added function get_img_at_mpp to class OpenSlideWSIReader of module w…
88002e8
Added get_img_at_mpp to class CuCIMWSIReader
a9fe772
Added function get_img_at_mpp to class TifffileWSIReader; changed res…
feac0dc
Small changes
8194026
Small changes
4df0b4b
Stein's Unbiased Risk Estimator (SURE) loss and Conjugate Gradient (#…
cxlcl d989c18
Renamed function to get_wsi_at_mpp
105f00b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5db27c1
Reformatted wsi_reader.py
NikolasSchmitz 18e82bd
auto updates (#7577)
monai-bot 5bb531e
Fixed return type
NikolasSchmitz 5214c56
Small fixes
NikolasSchmitz 3f055a9
Remove nested error propagation on `ConfigComponent` instantiate (#7569)
surajpaib 3264079
2872 implementation of mixup, cutmix and cutout (#7198)
juampatronics 22ecc8c
Merge branch 'dev' into 4980-get-wsi-at-mpp
bhashemian 6fcc4a6
Updated function get_wsi_at_mpp; added function _resize_to_mpp_res to…
NikolasSchmitz 4b0c9ba
Minor fixes: removed unnecessary comments
NikolasSchmitz d1a5e28
Merge branch 'dev' into 4980-get-wsi-at-mpp
NikolasSchmitz 66508e9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 441b462
Added function _compute_mpp_target_res to BaseWSIReader
NikolasSchmitz d73d739
Added new feature and merged updates from main repository
NikolasSchmitz feb6828
Added function _compute_mpp_target_res to BaseWSIReader
NikolasSchmitz 5461801
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e8c1544
Merge branch 'dev' into 4980-get-wsi-at-mpp
ericspod 59683bc
Added a function _compute_mpp_tolerances which checks the mpp toleran…
NikolasSchmitz 547442e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3e337b0
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz cc55b8a
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz 9eca8de
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz a8bb436
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz 6094ffd
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz c1dd7c3
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz 349c011
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz ca6796b
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz 52e0516
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz 54774d9
Updated WSI reader
NikolasSchmitz 2962016
Merge branch '4980-get-wsi-at-mpp' of https://github.com/NikolasSchmi…
NikolasSchmitz 3f87b10
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 801ca7f
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz 1c5a26c
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz e73cff8
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz aa4f2de
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz c09c7e2
Merge branch 'dev' into 4980-get-wsi-at-mpp
bhashemian 505e38b
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz df29f44
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz f70d0ef
Added get_wsi_at_mpp tests; fixed a few bugs
NikolasSchmitz 61fc9bf
Added function get_img_at_mpp to class OpenSlideWSIReader of module w…
a834514
Added get_img_at_mpp to class CuCIMWSIReader
c92475d
Added function get_img_at_mpp to class TifffileWSIReader; changed res…
5b988a2
Small changes
5168a12
Small changes
1437477
Stein's Unbiased Risk Estimator (SURE) loss and Conjugate Gradient (#…
cxlcl a4a78e3
Renamed function to get_wsi_at_mpp
b1ed4ff
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6b18e9b
Reformatted wsi_reader.py
NikolasSchmitz d74d4be
auto updates (#7577)
monai-bot d6d0cc2
Fixed return type
NikolasSchmitz 2f4388e
Small fixes
NikolasSchmitz d0a4881
Updated function get_wsi_at_mpp; added function _resize_to_mpp_res to…
NikolasSchmitz 7545148
Minor fixes: removed unnecessary comments
NikolasSchmitz b01bf63
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5c7822f
Added new feature and merged updates from main repository
NikolasSchmitz fd0d0cf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 234f23f
Added a function _compute_mpp_tolerances which checks the mpp toleran…
NikolasSchmitz 2730abe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9d817e7
Updated WSI reader
NikolasSchmitz 2afa6fb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8270658
Added get_wsi_at_mpp tests; fixed a few bugs
NikolasSchmitz 23e4a74
Added get_wsi_at_mpp tests; fixed a few bugs
NikolasSchmitz 787d30f
Added get_wsi_at_mpp tests; fixed a few bugs
NikolasSchmitz 0d9f1dd
Added get_wsi_at_mpp tests; fixed a few bugs
NikolasSchmitz 45182fa
Added get_wsi_at_mpp tests; fixed a few bugs
NikolasSchmitz a361fa2
Merge branch '4980-get-wsi-at-mpp' of https://github.com/NikolasSchmi…
NikolasSchmitz 832c14e
Added get_wsi_at_mpp tests; fixed a few bugs
NikolasSchmitz 5059b14
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz d644371
Merge branch 'dev' into 4980-get-wsi-at-mpp
NikolasSchmitz 922bbf1
Merge branch 'Project-MONAI:dev' into 4980-get-wsi-at-mpp
NikolasSchmitz 4249b48
DCO Remediation Commit for Nikolas Schmitz <nikolas.schmitz@rwth-aach…
NikolasSchmitz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add input validation for mpp parameter.
The
get_wsi_at_mpp
methods should validate thatmpp
is a tuple of positive floats to prevent runtime errors.Add validation at the beginning of each
get_wsi_at_mpp
method:Also applies to: 823-839, 1084-1100, 1321-1337
🤖 Prompt for AI Agents