Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed four test issues within test code. #7662

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

freddiewanah
Copy link
Contributor

Description

This PR fixed the three issues within the test code that could cause problems during CICD.

Three issues:

tests/test_pad_collation.py line 120: supposed to be assertEqual, but not assertTure? or it will always be true.
tests/test_to_numpy.py line 74: Same as above.
tests/test_auto3dseg.py line 370: typo? two same asserts next to each other.
tests/test_compose.py line 719, 725, 727: Should be assertEqual instead of assertTrue

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Han Wang <freddie.wanah@gmail.com>
@atbenmurray atbenmurray self-requested a review April 18, 2024 13:24
Copy link
Contributor

@atbenmurray atbenmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look sensible and correct

@atbenmurray
Copy link
Contributor

@KumoLiu the failures don't look related to the changes at a glance. Do we have some test configuration issue at the moment?

@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 18, 2024

Yes, the update from mlflow has caused some issues. The fix will be included in this PR: #7659.
Will merge this one after that.
Thanks.

@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 19, 2024

/build

@KumoLiu KumoLiu merged commit 224c47a into Project-MONAI:dev Apr 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants