Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix itk install error when python=3.8 #7719

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Apr 26, 2024

Fixes #7716

set python 3.9 for pythonapp.yml

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Apr 26, 2024

/build

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for this issue as we discussed today. This is partially dropping support for 3.8 as we're not testing as thoroughly but it's reaching end-of-life soon anyhow. Thanks!

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Apr 26, 2024

/build

1 similar comment
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Apr 28, 2024

/build

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Apr 29, 2024

/build

2 similar comments
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Apr 29, 2024

/build

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Apr 29, 2024

/build

@KumoLiu KumoLiu merged commit 4c193ea into Project-MONAI:dev Apr 29, 2024
28 checks passed
@KumoLiu KumoLiu deleted the itk branch April 29, 2024 06:18
marksgraham pushed a commit to marksgraham/MONAI that referenced this pull request Apr 30, 2024
Fixes Project-MONAI#7716

set python 3.9 for pythonapp.yml

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

itk install error in macOS-latest
2 participants