Scheduler Clip Fix #7855
Merged
Scheduler Clip Fix #7855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2024 15:56
Signed-off-by: virginiafdez <virginia.fernandez@kcl.ac.uk>
…i-dev Signed-off-by: virginiafdez <virginia.fernandez@kcl.ac.uk> # Conflicts: # monai/networks/schedulers/ddim.py
|
One of the fails is related to #7856. |
|
See #7857 for the fix that you might need here for the fails you're seeing with some tests. |
|
There are too many changes for Numpy 2.0 to do so I have #7859 to force a Numpy version <2.0. |
Signed-off-by: virginiafdez <virginia.fernandez@kcl.ac.uk>
ericspod
approved these changes
Jun 19, 2024
|
@KumoLiu @Nic-Ma I think we're good to merge this into this branch, @virginiafdez can then work on merging |
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
Fixes a bug in the inferer and adds clipping parameters to the DDIM/DDPM schedulers.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.