Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #8115

Closed
wants to merge 1 commit into from

Conversation

kartikshastrakar
Copy link

@kartikshastrakar kartikshastrakar commented Sep 26, 2024

•	Updated the PYTORCH_IMAGE to 23.08-py3, but ensure it’s still relevant for your application.
•	The requirements.txt handling avoids potential issues with conflicting torch versions, by removing it from the list before installing.
•	NGC client installation is optimized, and we use MD5 checks to ensure proper download.
•	Reduced Docker image size by cleaning up the apt cache and build files.

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

	•	Updated the PYTORCH_IMAGE to 23.08-py3, but ensure it’s still relevant for your application.
	•	The requirements.txt handling avoids potential issues with conflicting torch versions, by removing it from the list before installing.
	•	NGC client installation is optimized, and we use MD5 checks to ensure proper download.
	•	Reduced Docker image size by cleaning up the apt cache and build files.

Signed-off-by: Kartik Shastrakar <81631437+kartikshastrakar@users.noreply.github.com>
@kartikshastrakar
Copy link
Author

•	Updated the PYTORCH_IMAGE to 23.08-py3, but ensure it’s still relevant for your application.
•	The requirements.txt handling avoids potential issues with conflicting torch versions, by removing it from the list before installing.
•	NGC client installation is optimized, and we use MD5 checks to ensure proper download.
•	Reduced Docker image size by cleaning up the apt cache and build files.

@kartikshastrakar
Copy link
Author

merg is blocked

@kartikshastrakar
Copy link
Author

checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants