Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding load_submodules #8118

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

ericspod
Copy link
Member

Description

This restores load_modules for now to resolve importation issues. Doing a two-pass loading process seems to allow some references which normally Python wouldn't permit. The fact that these issues weren't caught in testing is rather strange, and only showed up when symbols in monai.apps were references in bundles. I'm not sure if this is all related to circular imports, if parts of MONAI aren't being tested properly, or the way the symbol resolution works within monai.bundle should be improved.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

…s creates needs to be sorted later

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@KumoLiu
Copy link
Contributor

KumoLiu commented Sep 27, 2024

Let's also include this test back then let me trigger more tests.
https://github.com/Project-MONAI/MONAI/blob/1.4.0rc9/tests/min_tests.py#L235

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod
Copy link
Member Author

Let's also include this test back then let me trigger more tests.
https://github.com/Project-MONAI/MONAI/blob/1.4.0rc9/tests/min_tests.py#L235

Ok that's back in now.

@KumoLiu
Copy link
Contributor

KumoLiu commented Sep 27, 2024

/build

@KumoLiu KumoLiu merged commit 8546be0 into Project-MONAI:dev Sep 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants