Skip to content

Update autoencoderkl_maisi.py to make it faster for non-tp cases #8331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented Feb 6, 2025

When there is no need to perform tensor parallel, skip all the unnecessary splitting steps

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Sorry, something went wrong.

Can-Zhao and others added 6 commits February 6, 2025 12:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
When there is no need to perform tensor parallel, skip all the unnecessary splitting steps
for more information, see https://pre-commit.ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…github.com> I, Can Zhao <69829124+Can-Zhao@users.noreply.github.com>, hereby add my Signed-off-by to this commit: efdc623 I, Can Zhao <69829124+Can-Zhao@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 131f7e6  Signed-off-by: Can Zhao <69829124+Can-Zhao@users.noreply.github.com>
for more information, see https://pre-commit.ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 13, 2025

Hi @Can-Zhao, since we will release 1.5 soon, do you plan to include this minor change?

@Can-Zhao Can-Zhao closed this Apr 30, 2025
@Can-Zhao Can-Zhao deleted the maisi branch April 30, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants