Downgrade filelock version #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
CI job fails for packaging (it runs integration tests) with an error for cv2 |
|
Hi @KumoLiu , it looks like the proposal to remove opencv-python-headless is not working. Can we try another package instead, do you have idea on which package can replace |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
lets go one simple PR first to fix |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
KumoLiu
changed the title
SachidanandAlle
approved these changes
May 7, 2024
requirements.txt
Outdated
| @@ -28,13 +28,12 @@ pydicom==2.4.4 | |||
| pydicom-seg==0.4.1 | |||
| pynetdicom==2.0.2 | |||
| pynrrd==1.0.0 | |||
| opencv-python-headless==4.9.0.80 | |||
There was a problem hiding this comment.
Is opencv a direct dependency installed by monai.. monailabel needs this as a direct dependency
requirements.txt
Outdated
| passlib==1.7.4 | ||
| python-jose[cryptography]==3.3.0 | ||
| bcrypt==4.1.2 | ||
| shapely==2.0.4 | ||
| requests==2.31.0 | ||
| requests-toolbelt==1.0.0 | ||
| urllib3==2.2.1 | ||
| opencv |
There was a problem hiding this comment.
opencv and opencv-python-headless both?
setup.cfg
Outdated
| @@ -54,13 +54,12 @@ install_requires = | |||
| pydicom-seg==0.4.1 | |||
| pynetdicom==2.0.2 | |||
| pynrrd==1.0.0 | |||
| opencv-python-headless==4.9.0.80 | |||
There was a problem hiding this comment.
removing this will not help open source monailabel users to do pip-install and run monailabel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version requirement for filelock and nni MONAI#7744
https://github.com/microsoft/nni/blob/767ed7f22e1e588ce76cbbecb6c6a4a76a309805/dependencies/required.txt#L4