Skip to content

Use POSIX path for App Runner to handle Windows path #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gigony merged 6 commits into from
Sep 28, 2021
Merged

Use POSIX path for App Runner to handle Windows path #153

gigony merged 6 commits into from
Sep 28, 2021

Conversation

@gigony
Copy link
Collaborator

@gigony gigony commented Sep 24, 2021 •
edited
Loading

  • Use POSIX path for App Runner
  • Do not use shlex.quote for Windows
  • Update .bumpversion.cfg to sign-off commit
  • Bump version to 0.1.1rc2

Created 0.1.1rc2 package on test PyPI for test.

pip install -i https://test.pypi.org/simple/ monai-deploy-app-sdk==0.1.1rc2

resolve #152

@gigony gigony self-assigned this Sep 24, 2021
@gigony gigony added the bug Something isn't working label Sep 24, 2021
@gigony gigony added this to the v0.1.0 milestone Sep 24, 2021
@gigony gigony mentioned this pull request Sep 24, 2021
Closed
@gigony
Do not use shlex.quote for Windows
de6d57e 
- shlex.quote() would remove '\' character on Windows path
- Use 'shell=True' to execute shell command

Signed-off-by: Gigon Bae <gbae@nvidia.com>
@gigony
Bump version: 0.1.0 → 0.1.1rc1
df52b70 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
@gigony
Update .bumpversion.cfg to sign-off commit
337db38 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
@gigony
Use POSIX path for App Runner
f9903b9 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
@gigony
Bump version: 0.1.1rc1 → 0.1.1rc2
2030ac9 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
MMelQin
MMelQin approved these changes Sep 24, 2021
View reviewed changes
Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sure has also fixed some of the less robust path manipulations.

@gigony
Update installation guide - CUDA on WSL
6ddf3f8 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
bhatt-piyush
bhatt-piyush approved these changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@bhatt-piyush bhatt-piyush left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Gigon

@gigony gigony merged commit bbc3894 into main Sep 28, 2021
@gigony gigony mentioned this pull request Oct 25, 2021
Merged
@MMelQin MMelQin deleted the use_posixpath branch November 5, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhatt-piyush bhatt-piyush bhatt-piyush approved these changes

@MMelQin MMelQin MMelQin approved these changes

Assignees

@gigony gigony

Labels

bug Something isn't working

Projects

None yet

Milestone

v0.1.0

Development

Successfully merging this pull request may close these issues.

[BUG] App Runner cannot handle Windows Path properly

4 participants

@gigony @bhatt-piyush @MMelQin