Updated the png converter operator following changes to Image ndarray index order. #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… index order. Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
mocsharp
approved these changes
Feb 12, 2022
Collaborator
Author
|
Thanks @mocsharp for the review. The change had also been tested with its built-in test method in dev env. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Image object that is created by the DICOM to Image converter now contains a numpy array with index order of DHW, the same way as ITK does. So, the depth (slicing along this axis for the original DICOM slice) is now the first dim, and the indexing needs to change accordingly.
Signed-off-by: mmelqin mingmelvinq@nvidia.com