Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pancreas Seg app, multi-model app, and Jupyter Notebook tutorial #315

Merged
merged 11 commits into from
Oct 27, 2022

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Jul 17, 2022

In this PR,

  • new Pancreas Seg app is added for the Pancreas Seg model bundle published in the Model Zoo. Please note that this new app is identical to the Spleen Seg App, except for the change of name from Spleen to Pancreas in a half dozen places. The App could well have been parameterized, on the model only, for a set of segmentation model bundles in the Model Zoo, but, there has been a request to build an app for each of the few named bundles.
  • add a new app to demonstrate how to support multiple models in the same app. It is more about model file organization and how to access the named model within the application than showing how a model's output can be used as the input to the next model in a ensemble, e.g. Seg model output used as input to Classification. This is because there have not been such bundles in the Model Zoo. There are already use cases for this in clinical research, and this app will help the deploy app developer.
  • add the Jupyter tutorial for the multi model application. Note the use of the 22.08 version of the Nvidia PyTorch container image to avoid a torch runtime compatibility issue. A separate PR has been raised to test app compatibility and hence set the default base image to the latest Nvidia PyTorch container image.
  • minor wording change in the Spleen Seg Jupyter notebook

Note: the SonarCloud reported failure is on code duplication, as noted in Item 1 above.

Signed-off-by: mmelqin mingmelvinq@nvidia.com

@MMelQin MMelQin added architectural story Work related to architecture enhancement New feature or request labels Jul 17, 2022
@MMelQin MMelQin self-assigned this Jul 17, 2022
@MMelQin MMelQin changed the title [WIP] Add the multi-model example Add the multi-model example Jul 20, 2022
@MMelQin
Copy link
Collaborator Author

MMelQin commented Jul 21, 2022

SonarCloud Code Analysis is false positive and complains about code duplication, 19%, for no reason.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
18.3% 18.3% Duplication

Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Now the whole app works with both Spleen and Pancreas bundles

Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
…g check.

Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
@MMelQin MMelQin force-pushed the mqin/add_multi-model_multi-AI_example branch from 4731d4a to 380f5e3 Compare October 22, 2022 20:26
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
28.6% 28.6% Duplication

@MMelQin MMelQin changed the title Add the multi-model example Add Pancreas Seg app, multi-model app, and Jupyter Notebook tutorial Oct 24, 2022
@MMelQin MMelQin requested review from CPBridge and dbericat October 24, 2022 01:26
@Nic-Ma Nic-Ma requested a review from mingxin-zheng October 24, 2022 03:00
Copy link
Member

@dbericat dbericat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MMelQin MMelQin requested a review from aihsani October 25, 2022 21:26
@MMelQin MMelQin merged commit c5ce6c4 into main Oct 27, 2022
@MMelQin MMelQin deleted the mqin/add_multi-model_multi-AI_example branch February 3, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architectural story Work related to architecture enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants