-
Notifications
You must be signed in to change notification settings - Fork 60
Add DICOM PDF Writer and split dicom_utils common module out of Text SR Writer #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
|
SonarCloud Quality Gate failed.
|
|
Reviewed off-line. |
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…SR Writer (Project-MONAI#366) * Created dicom_utils for common obj and func, and added DICOM PDF Writer Signed-off-by: M Q <mingmelvinq@nvidia.com> * Formatting update Signed-off-by: M Q <mingmelvinq@nvidia.com> * Fix flake8 complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Address mypy complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Formatting Signed-off-by: M Q <mingmelvinq@nvidia.com> * Change to use full path of dicom_utils Signed-off-by: M Q <mingmelvinq@nvidia.com> * Replace Union with Optional Signed-off-by: M Q <mingmelvinq@nvidia.com> * Replace unused Union Signed-off-by: M Q <mingmelvinq@nvidia.com> * Update the year in the copyright notice Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jul 17, 2025
…SR Writer (Project-MONAI#366) * Created dicom_utils for common obj and func, and added DICOM PDF Writer Signed-off-by: M Q <mingmelvinq@nvidia.com> * Formatting update Signed-off-by: M Q <mingmelvinq@nvidia.com> * Fix flake8 complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Address mypy complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Formatting Signed-off-by: M Q <mingmelvinq@nvidia.com> * Change to use full path of dicom_utils Signed-off-by: M Q <mingmelvinq@nvidia.com> * Replace Union with Optional Signed-off-by: M Q <mingmelvinq@nvidia.com> * Replace unused Union Signed-off-by: M Q <mingmelvinq@nvidia.com> * Update the year in the copyright notice Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








This PR is to:
By the way, the SonarCloud failures are false positives, on some bogus code duplication findings. I have reviewed them and marking them as info.
Screenshot of the DICOM Text SR and Encapsulated PDF viewed in MicroDICOM:
Screenshot of actual PDF opened from MicroDICOM

Signed-off-by: M Q mingmelvinq@nvidia.com