Skip to content

Conversation

@KavinKrishnan
Copy link
Collaborator

No description provided.

@KavinKrishnan KavinKrishnan requested a review from gigony September 9, 2021 00:09
Copy link
Collaborator

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KavinKrishnan for updating this!
Left a comment regarding test clean-up.

@KavinKrishnan KavinKrishnan force-pushed the kavin/update_packager_tests_dummy_code branch 3 times, most recently from 0f62372 to 064ed48 Compare September 10, 2021 20:34
Copy link
Collaborator

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit with signature: https://probot.github.io/apps/dco/

Approve with a minor comment.

@gigony gigony added the bug Something isn't working label Sep 10, 2021
@gigony gigony added this to the v0.1.0 milestone Sep 10, 2021
@KavinKrishnan KavinKrishnan force-pushed the kavin/update_packager_tests_dummy_code branch from 064ed48 to d4b98ca Compare September 10, 2021 23:01
@KavinKrishnan KavinKrishnan merged commit 480b57e into main Sep 10, 2021
Signed-off-by: kavink <kavink@nvidia.com>
@gigony
Copy link
Collaborator

gigony commented Sep 13, 2021

This resolves #92

@MMelQin MMelQin deleted the kavin/update_packager_tests_dummy_code branch November 5, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants