Skip to content

Conversation

@mocsharp
Copy link
Collaborator

Refactor the IMinioAdmin interface into the base project and make it more generic for other plugins.

@mocsharp mocsharp added this to the 0.1.0 milestone Jun 17, 2022
@mocsharp mocsharp requested a review from lillie-dae June 17, 2022 23:00
@mocsharp mocsharp self-assigned this Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #15 (5810e2b) into release/0.1.0 (a0dd398) will increase coverage by 1.18031%.
The diff coverage is 8.79121%.

❗ Current head 5810e2b differs from pull request most recent head ef4b919. Consider uploading reports for the commit ef4b919 to get more accurate results

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/0.1.0         #15         +/-   ##
=======================================================
+ Coverage       31.29252%   32.47283%   +1.18031%     
=======================================================
  Files                 21          22          +1     
  Lines                735         736          +1     
  Branches              54          48          -6     
=======================================================
+ Hits                 230         239          +9     
+ Misses               504         495          -9     
- Partials               1           2          +1     
Flag Coverage Δ
unittests 32.47283% <8.79121%> (+1.18031%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Plugins/MinIO/MinIoStorageService.cs 0.00000% <0.00000%> (ø)
src/Plugins/MinIO/StorageAdminService.cs 0.00000% <0.00000%> (ø)
src/Plugins/MinIO/Tests/ServiceRegistrationTest.cs 100.00000% <ø> (+22.22221%) ⬆️
src/S3Policy/Policies/PolicyRequest.cs 0.00000% <0.00000%> (ø)
...orage/Configuration/StorageServiceConfiguration.cs 100.00000% <ø> (ø)
...Storage/Tests/IServiceCollectionExtensionsTests.cs 77.21519% <ø> (ø)
.../Plugins/MinIO/Extensions/MinioPolicyExtensions.cs 77.77778% <83.33333%> (+77.77778%) ⬆️
src/Plugins/MinIO/ServiceRegistration.cs 100.00000% <100.00000%> (ø)
...c/Plugins/MinIO/Tests/MinioPolicyExtensionsTest.cs 100.00000% <100.00000%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0dd398...ef4b919. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/refactor-admin-service branch from 5810e2b to ef4b919 Compare June 21, 2022 16:54
@mocsharp mocsharp merged commit 6e24614 into release/0.1.0 Jun 21, 2022
@mocsharp mocsharp deleted the vchang/refactor-admin-service branch June 21, 2022 16:57
@github-actions
Copy link

🎉 This issue has been resolved in version 0.1.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

3 participants