Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Mar 16, 2023

Description

  • Remove use of .NET 7 nuget packages.
  • Use 17.2.x of System.IO.Abstractions

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Mar 16, 2023
@mocsharp mocsharp added this to the 0.2.15 milestone Mar 16, 2023
@mocsharp mocsharp self-assigned this Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #200 (17391e4) into develop (f321edd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop        #200   +/-   ##
=============================================
  Coverage   80.42453%   80.42453%           
=============================================
  Files             31          31           
  Lines           1272        1272           
  Branches          72          72           
=============================================
  Hits            1023        1023           
  Misses           213         213           
  Partials          36          36           
Flag Coverage Δ
unittests 80.42453% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f321edd...17391e4. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/fix-packages branch from 47e22d6 to 292cc0c Compare March 16, 2023 00:45
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@neildsouth neildsouth merged commit 869df4d into develop Mar 16, 2023
@neildsouth neildsouth deleted the vchang/fix-packages branch March 16, 2023 10:46
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.15 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants