Skip to content

Conversation

@jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Apr 22, 2022

Description
Add MinIO folder and credential creation to Storage repository

Status

Draft

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@jackschofield23 jackschofield23 force-pushed the jschofield/addcredentialgeneration branch from f33f238 to 9434aa7 Compare April 22, 2022 12:07
@jackschofield23 jackschofield23 marked this pull request as ready for review April 22, 2022 12:07
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #5 (69f25a2) into release/0.1.0 (171ab77) will decrease coverage by 64.93056%.
The diff coverage is 49.00990%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           release/0.1.0          #5          +/-   ##
========================================================
- Coverage      100.00000%   35.06944%   -64.93056%     
========================================================
  Files                  1           7           +6     
  Lines                  2         288         +286     
  Branches               0          10          +10     
========================================================
+ Hits                   2         101          +99     
- Misses                 0         187         +187     
Flag Coverage Δ
unittests 35.06944% <49.00990%> (-64.93056%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Storage/Configuration/ConfigurationKeys.cs 0.00000% <0.00000%> (ø)
src/Storage/MinIo/MinIoStorageService.cs 0.00000% <0.00000%> (ø)
src/Storage/Common/Extensions/PolicyExtensions.cs 100.00000% <100.00000%> (ø)
...rc/Storage/Test/Extensions/PolicyExtensionsTest.cs 100.00000% <100.00000%> (ø)
...rc/Storage/Configuration/ConfigurationException.cs 0.00000% <0.00000%> (ø)
src/Storage/Common/VirtualFileInfo.cs 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171ab77...69f25a2. Read the comment docs.

@jackschofield23 jackschofield23 force-pushed the jschofield/addcredentialgeneration branch 2 times, most recently from e9dd457 to fb0e2e0 Compare April 22, 2022 12:55
Signed-off-by: jackschofield23 <jack.schofield@answerdigital.com>
Signed-off-by: jackschofield23 <jack.schofield@answerdigital.com>
Signed-off-by: jackschofield23 <jack.schofield@answerdigital.com>
@jackschofield23 jackschofield23 force-pushed the jschofield/addcredentialgeneration branch from a57bc56 to 69f25a2 Compare April 27, 2022 15:24
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

37.5% 37.5% Coverage
3.9% 3.9% Duplication

@jackschofield23 jackschofield23 merged commit c90e1c6 into release/0.1.0 Apr 28, 2022
@mocsharp mocsharp deleted the jschofield/addcredentialgeneration branch September 20, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants