Skip to content

Conversation

@jackschofield23
Copy link
Contributor

Description
Add artifact verification to the storage service

Status
Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #6 (35590f7) into release/0.1.0 (c90e1c6) will decrease coverage by 1.51462%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/0.1.0          #6         +/-   ##
=======================================================
- Coverage       35.06944%   33.55482%   -1.51463%     
=======================================================
  Files                  7           7                 
  Lines                288         301         +13     
  Branches              10          11          +1     
=======================================================
  Hits                 101         101                 
- Misses               187         200         +13     
Flag Coverage Δ
unittests 33.55482% <0.00000%> (-1.51463%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Storage/MinIo/MinIoStorageService.cs 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90e1c6...35590f7. Read the comment docs.

@jackschofield23 jackschofield23 self-assigned this May 20, 2022
@jackschofield23 jackschofield23 requested a review from mocsharp May 20, 2022 10:00
Copy link
Collaborator

@mocsharp mocsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackschofield23 jackschofield23 merged commit fcb7fa7 into release/0.1.0 May 20, 2022
@jackschofield23 jackschofield23 deleted the jschofield/add-artifact-verification branch May 20, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants