Skip to content

Conversation

@lillie-dae
Copy link
Contributor

@lillie-dae lillie-dae commented May 30, 2022

Changes required for #112.

Description

This is the changes required to generate Read Only users and interface with MinioAdmin service.

Status

In Progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
  • Any new files have copyright headers
  • Code coverage above 70%
  • TODO items resolved

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae lillie-dae marked this pull request as ready for review May 30, 2022 14:25
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

23.5% 23.5% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #8 (9e8f7e9) into release/0.1.0 (66f4671) will decrease coverage by 11.52152%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           release/0.1.0          #8          +/-   ##
========================================================
- Coverage       32.47588%   20.95436%   -11.52152%     
========================================================
  Files                  7          12           +5     
  Lines                311         482         +171     
  Branches              17          31          +14     
========================================================
  Hits                 101         101                  
- Misses               210         381         +171     
Flag Coverage Δ
unittests 20.95436% <0.00000%> (-11.52152%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Deploy.Storage.Core/Extensions/PolicyExtensions.cs 53.50877% <0.00000%> (ø)
...rc/Monai.Deploy.Storage.Core/Policies/Converter.cs 0.00000% <0.00000%> (ø)
src/Monai.Deploy.Storage.Core/Policies/Policy.cs 0.00000% <0.00000%> (ø)
...onai.Deploy.Storage.Core/Policies/PolicyRequest.cs 0.00000% <0.00000%> (ø)
...inioAdminShell/Extensions/MinioPolicyExtensions.cs 0.00000% <0.00000%> (ø)
src/Monai.Deploy.Storage.MinioAdminShell/Shell.cs 0.00000% <0.00000%> (ø)
src/Storage/MinIo/MinIoStorageService.cs 0.00000% <ø> (ø)
src/Storage/Test/DummyTest.cs 100.00000% <ø> (ø)
...rc/Storage/Test/Extensions/PolicyExtensionsTest.cs 100.00000% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f4671...9e8f7e9. Read the comment docs.

@lillie-dae lillie-dae merged commit 7ce382d into release/0.1.0 May 31, 2022
@lillie-dae lillie-dae deleted the sto-112-generate-temp-cre branch May 31, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants