Skip to content

Fix allowed Argo parameter list and logging scope data not being rendered correctly #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

Fix allowed Argo parameter list and logging scope data not being rendered correctly #870

merged 2 commits into from
Sep 5, 2023

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Sep 1, 2023 •
edited
Loading

Description

  • Fix Argo parameter validation keys
  • Fix to correctly serialize logger scope values
  • Change Argo podStartTime and podFinishTime to use the universal full ("U") format specifier

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp
Fix argo parameter validation keys.
01998a2 
Fix to correctly serialize logger scope values.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Sep 1, 2023
@mocsharp mocsharp added this to the 0.1.28 milestone Sep 1, 2023
@mocsharp mocsharp requested a review from neildsouth September 1, 2023 22:31
@mocsharp mocsharp self-assigned this Sep 1, 2023
@mocsharp mocsharp changed the title Fix argo parameter validation keys and. Fix argo parameter validation keys Sep 1, 2023
@mocsharp mocsharp changed the title Fix argo parameter validation keys Fix allowed Argo parameter list and logging scope data not being rendered correctly Sep 1, 2023
@mocsharp
Fix unit tests
9363b4a 
Change argo pod date time to use the universal full ("U") format specifier

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.2% 87.2% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mocsharp mocsharp merged commit 0aca28d into develop Sep 5, 2023
@mocsharp mocsharp deleted the vchang/bug-fixes branch September 5, 2023 17:09
@github-actions
Copy link

🎉 This issue has been resolved in version 0.1.29 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neildsouth neildsouth neildsouth approved these changes

Assignees

@mocsharp mocsharp

Labels
bug Something isn't working
Projects
Clinical Data Pipelines
Status: Done
Milestone
0.1.29
Development

Successfully merging this pull request may close these issues.
2 participants
@mocsharp @neildsouth