Skip to content

Ai 226 #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 11, 2023
Merged

Ai 226 #887

merged 7 commits into from
Oct 11, 2023

Conversation

neildsouth
Copy link
Collaborator

@neildsouth neildsouth commented Oct 9, 2023 •
edited
Loading

Description

Fixes # .

Canceling Argo tasks never completes

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@neildsouth
adding more logging
e1b1a6d 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
merge in from dev
4004174 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
fix status setting
414bd7e 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
fix upo index for status
b482888 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
added additional exception to handle 404
ee57b9a 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
removed commented out line
1099d42 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
removed a single space
a664dbf 
Signed-off-by: Neil South <neil.south@answerdigital.com>
samrooke
samrooke reviewed Oct 11, 2023
View reviewed changes
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

20.6% 20.6% Coverage
8.5% 8.5% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@neildsouth neildsouth merged commit 94576ce into develop Oct 11, 2023
@neildsouth neildsouth deleted the AI-226 branch October 11, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrooke samrooke samrooke left review comments

@lillie-dae lillie-dae lillie-dae approved these changes

@mehranrashid mehranrashid mehranrashid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neildsouth @samrooke @lillie-dae @mehranrashid