-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynUNet needs updating for deep_supervision #106
Comments
The dynunet returns list (containing the output tensor). Had it returned a tensor in validation mode, it would have been easier to use.
|
I will have a try to run the notebook tomorrow, thanks for your issue report. Thanks. |
Possibly best to make any changes in this PR, as it will already have PEP8 modifications (and |
Hi @saruarlive and @rijobro , I just submitted a commit to fix this issue in that branch: c61cfd1 Thanks. |
sure, could you please help review the changes? @Nic-Ma @yiheng-wang-nv @ericspod |
@saruarlive This was helpful for me. I was finally able to get DynUNet working for the specified tutorial. |
Hi all, I just submitted a PR to update the DynUNet tutorial to meet the changes here. Now, the forward function will only return a single tensor (for both training and eval mode, with or without deep supervision). |
Describe the bug
Following this PR to DynUNet, the corresponding notebook needs updating.
I tried simply removing
deep_supervision = True
from the constructor, but this wasn't enough.The subsequent error is attached here: dynunet.txt.
@Nic-Ma I think you might best know what needs to be changed here.
The text was updated successfully, but these errors were encountered: