-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bending energy and diffusion regularizer demo #1587
Comments
I agree that covering bending energy and diffusion in the same notebook makes sense. I think that the scale invariance and scaling law stuff in the personal demo that you and I put together should not go into the tutorials repo. Or at least it should be simplified before going in, since it was originally designed to verify that an algorithm was behaving correctly and not really designed to be tutorial material. Someone interested in a tutorial on bending/diffusion loss functions would just want to see an example DDF and see the loss functions applied. Then we can be like "here's what Thanks for posting this task and for any work that you end up doing on it :D |
Thank you! And I agree that scaling laws should not go into the tutorial repo. With that being said, I think what are necessary to include in this tutorial would be
And the emphasis should be on how to use these two losses instead of on the more technical aspects. I will go ahead and put together a draft :) |
Fixes #1587. ### Description As mentioned in #1587, the notebook should contain - [x] Formula for bending energy and diffusion, - [x] Demonstration that bending energy is not scale invariant while diffusion is not scale invariant in some cases (maybe display examples of these cases), and - [x] How both losses are made invariant by specifying `normalize=True`. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: kaibo <ktang@unc.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ebrahim Ebrahim <ebrahim.ebrahim@kitware.com>
Fixes Project-MONAI#1587. ### Description As mentioned in Project-MONAI#1587, the notebook should contain - [x] Formula for bending energy and diffusion, - [x] Demonstration that bending energy is not scale invariant while diffusion is not scale invariant in some cases (maybe display examples of these cases), and - [x] How both losses are made invariant by specifying `normalize=True`. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: kaibo <ktang@unc.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ebrahim Ebrahim <ebrahim.ebrahim@kitware.com>
Is your feature request related to a problem? Please describe.
Originally posted by @KumoLiu in Project-MONAI/MONAI#7272 (comment)
Describe the solution you'd like
Add the demo, similar to the one here.
Describe alternatives you've considered
/
Additional context
The text was updated successfully, but these errors were encountered: