Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orientation before spacing #545

Closed
wyli opened this issue Feb 14, 2022 · 0 comments · Fixed by #546
Closed

orientation before spacing #545

wyli opened this issue Feb 14, 2022 · 0 comments · Fixed by #546

Comments

@wyli
Copy link
Contributor

wyli commented Feb 14, 2022

Is your feature request related to a problem? Please describe.
the orientation transform should be put before any anisotropic spatial scalings
so that data from different orientations are scaled in the same axes

Spacingd(keys=["image", "label"], pixdim=(
    1.5, 1.5, 2.0), mode=("bilinear", "nearest")),
Orientationd(keys=["image", "label"], axcodes="RAS"),

should be

Orientationd(keys=["image", "label"], axcodes="RAS"),
Spacingd(keys=["image", "label"], pixdim=(
    1.5, 1.5, 2.0), mode=("bilinear", "nearest")),

this is a correct example:

LoadImaged(keys=["image", "label"]),
EnsureChannelFirstd(keys=["image", "label"]),
Orientationd(keys=["image", "label"], axcodes="RAS"),
Spacingd(keys=["image", "label"], pixdim=spacing, mode=("bilinear", "nearest"), align_corners=(True, True)),

wyli added a commit to wyli/MONAI that referenced this issue Feb 14, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit to Project-MONAI/MONAI that referenced this issue Feb 14, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit to wyli/tutorials that referenced this issue Feb 14, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli mentioned this issue Feb 14, 2022
1 task
@wyli wyli closed this as completed in #546 Feb 15, 2022
wyli added a commit that referenced this issue Feb 15, 2022
* fixes #545

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update 3d image transforms tutorial

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit to wyli/MONAI that referenced this issue Feb 16, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this issue Apr 21, 2024
* fixes Project-MONAI#545

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update 3d image transforms tutorial

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant