-
Notifications
You must be signed in to change notification settings - Fork 761
Updating workflow to use Github CPU runner #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Hi @KumoLiu this is the solution I think for getting the tests running again using CPU runners. One issue that we'll find is notebooks will have to run under CPU, some will be very slow as a result plus many in the repo which were tested with GPU cannot be retested now. We can make this change now to put through the PRs we have waiting, or we can change branch rules to allow repo owners to circumvent stuck tests. Thoughts? |
Hi @ericspod, yes. we can merge this one now to put through the PRs we have waiting and also let me change the premerge-notebools as a not "required" check, then if there are some tests must be runned on the GPU, the PR will not stuck as well. What do you think? |
Sounds good, let's get PRs through but run tests where as much as we can for now. |
Fixes #2031.
Description
This will change the failing CICD check to use Github CPU runners.
Checks
./figure
folder./runner.sh -t <path to .ipynb file>