628 Update performance profiling #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
for more information, see https://pre-commit.ci
yiheng-wang-nv
changed the title
|
Hi @dongyang0122 , could you please help to double check the changes of the radiology side? I checked the generated |
bhashemian
reviewed
Mar 29, 2022
wyli
approved these changes
Mar 30, 2022
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
* update performance profilling Signed-off-by: Yiheng Wang <vennw@nvidia.com> * update pathology requirements Signed-off-by: Yiheng Wang <vennw@nvidia.com> * keep the old folder Signed-off-by: Yiheng Wang <vennw@nvidia.com> * use nsys for radiology Signed-off-by: Yiheng Wang <vennw@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang vennw@nvidia.com
Fixes #628 .
Description
For
pathology, the nsys profile works fine, thus I did not change any code, but for the required libs, I did some modification to avoid installing unused libs, and ensure all necessary libs are installed.For
radiology, thedlprofrelated places are totally removed andnsys profilehas been used.All modifications have been tested locally with a new initialized environment (created for pathology and radiology separately) via using:
Status
Ready
Checks
./runner [-p <regex_pattern>]