Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coordinate_calculation as namespace? #1367

Closed
TheMarex opened this issue Jan 29, 2015 · 2 comments
Closed

coordinate_calculation as namespace? #1367

TheMarex opened this issue Jan 29, 2015 · 2 comments
Labels
Discussion

Comments

@TheMarex
Copy link
Member

Why is coordinate_calculation a struct with static members and not a simply a namespace?

Also IMHO, it seems more appropriate to place it in algorithms or util.

/cc @DennisOSRM
@DennisOSRM
Copy link
Collaborator

Yeah, fair point. Something to refactor on a slow day.

TheMarex added a commit that referenced this issue Aug 6, 2015
@TheMarex
Move calculate_coordinate to algorithms/
755807b 
Fixes #1367
TheMarex added a commit that referenced this issue Aug 7, 2015
@TheMarex
Move calculate_coordinate to algorithms/
b7ea64d 
Fixes #1367
TheMarex added a commit that referenced this issue Sep 1, 2015
@TheMarex @chaupow
Move calculate_coordinate to algorithms/
14e63eb 
Fixes #1367
@daniel-j-h
Copy link
Member

Fyi, the code base has more of those, e.g. struct bearing, struct cast, in the utils directory.
I already fixed those in #1661.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daniel-j-h @TheMarex @DennisOSRM