Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_turn: turn.roads_on_the_left does not contain incoming roads #5128

Closed
themylogin opened this issue Jul 2, 2018 · 1 comment
Closed

Comments

@themylogin
Copy link
Contributor

themylogin commented Jul 2, 2018

I've discovered that

  • turn.roads_on_the_left does not contain incoming roads
  • turn.roads_on_the_right does not contain outgoing roads

The following test fails:


    Scenario: Turns should have correct information of other roads at intersection III
        Given the node map
            """
              b
              |
            a-c-d
              |
              e
            """
        And the ways
            | nodes | highway       | oneway |
            | ac    | motorway      | yes    |
            | cd    | motorway_link | yes    |
            | bc    | primary       | yes    |
            | cb    | primary_link  | yes    |
            | ce    | secondary     | yes    |
            | ec    | secondary_link| yes    |
        And the data has been saved to disk

        When I run "osrm-extract --profile {profile_file} {osm_file}"
        Then it should exit successfully
        # Turn acd
        # on the left there should be bc and cb
        And stdout should contain /roads_on_the_left \[[12]\] speed: [0-9]+, is_incoming: true, is_outgoing: false, highway_turn_classification: [0-9]+, access_turn_classification: 0, priority_class: 4/
        And stdout should contain /roads_on_the_left \[[12]\] speed: [0-9]+, is_incoming: false, is_outgoing: true, highway_turn_classification: [0-9]+, access_turn_classification: 0, priority_class: 5/
        # on the left there should be ce and ec
        And stdout should contain /roads_on_the_right \[[12]\] speed: [0-9]+, is_incoming: false, is_outgoing: true, highway_turn_classification: [0-9]+, access_turn_classification: 0, priority_class: 6/
        And stdout should contain /roads_on_the_right \[[12]\] speed: [0-9]+, is_incoming: true, is_outgoing: false, highway_turn_classification: [0-9]+, access_turn_classification: 0, priority_class: 7/
@systemed
Copy link
Member

Fixed with #5131 merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants